Merged
Conversation
…producing result are next steps
feat:Implement single column aggregations, Implement group by statments, implement having statments
Fix/memory leaks
Feat/sort operator
feat:implement Distinct operator |test included
feat:Implement hash join
Documentation:Implement all intergration test
Contributor
There was a problem hiding this comment.
Pull request overview
This "Pre release" PR prepares the codebase for release by adding comprehensive integration test data, implementing new operators (DISTINCT, HAVING), improving code quality, and cleaning up TODOs. The changes primarily focus on the backend SQL optimization engine written in Go.
- Added large CSV test datasets (1000 rows each) for integration testing
- Implemented DISTINCT and HAVING operators with comprehensive tests
- Added PrettyPrint functionality for RecordBatch debugging
- Cleaned up context usage (context.TODO → context.Background)
- Removed placeholder files and TODO comments
- Refactored code for better maintainability
Reviewed changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
intergration_test_data_1.csv |
New 1000-row test dataset with user data (Note: filename has spelling error) |
intergration_test_data_2.csv |
New 1000-row test dataset with department data (Note: filename has spelling error) |
substrait_test.go |
Updated test ID and context usage |
t1_test.go |
Comprehensive new unit tests for all operators |
intergration_test.go |
New integration tests composing multiple operators |
record.go |
Added PrettyPrint and ReleaseArrays helper functions |
projectExec.go |
Refactored field naming and cleanup logic |
projectExecExpr_test.go |
Cleaned up type casting in literal expressions |
parquet.go |
Updated context usage |
custom.go |
Added NewInMemoryProjectExecFromArrays helper |
limit.go |
Implemented DISTINCT operator |
limit_test.go |
Added comprehensive DISTINCT operator tests |
having.go |
Implemented HAVING operator |
sum.go |
Removed empty placeholder file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.